Add 'deadline' to HttpResponse, making it possible to give a max duration for the liveness of the r…

Add 'deadline' to HttpResponse, making it possible to give a max duration for the liveness of the response.

BUG=https://code.google.com/p/dart/issues/detail?id=8425
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25408

[Søren Gjesse, 2013-07-24 11:29:26]

lgtm

https://codereview.chromium.org/19668013/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/19668013/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1116: final Socket socket;
_socket.

[Anders Johnsen, 2013-07-24 12:16:25]

PTAL, was missing the test.

https://codereview.chromium.org/19668013/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/19668013/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1116: final Socket socket;
On 2013/07/24 11:29:26, Søren Gjesse wrote:
> _socket.

It's intentionally not private. The _HttpOutgoing is never returned to the user,
so I use the non-private marking to indicate that it's used from outside this
class.

[Søren Gjesse, 2013-07-24 12:29:51]

lgtm

https://codereview.chromium.org/19668013/diff/5001/tests/standalone/io/http_r...
File tests/standalone/io/http_response_deadline_test.dart (right):

https://codereview.chromium.org/19668013/diff/5001/tests/standalone/io/http_r...
tests/standalone/io/http_response_deadline_test.dart:47: return new
Future.delayed(const Duration(milliseconds: 500), () {
Even though we are in the same VM timing issues could make the two timers fire
"at the same time". But still the dead line timer will fire first, so it should
not be flaky as socket.destroy is sync.

[Anders Johnsen, 2013-07-24 12:45:12]

Committed patchset #3 manually as r25408 (presubmit successful).

[Anders Johnsen, 2013-07-24 12:46:23]

https://codereview.chromium.org/19668013/diff/5001/tests/standalone/io/http_r...
File tests/standalone/io/http_response_deadline_test.dart (right):

https://codereview.chromium.org/19668013/diff/5001/tests/standalone/io/http_r...
tests/standalone/io/http_response_deadline_test.dart:47: return new
Future.delayed(const Duration(milliseconds: 500), () {
On 2013/07/24 12:29:51, Søren Gjesse wrote:
> Even though we are in the same VM timing issues could make the two timers fire
> "at the same time". But still the dead line timer will fire first, so it
should
> not be flaky as socket.destroy is sync.

Reworked the timers a bit.