Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 19668003: Formatter check-point (blank-space preservation experiment). (Closed)

Created:
7 years, 5 months ago by pquitslund
Modified:
7 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Formatter check-point (blank-space preservation experiment). Possibly not the long-term approach but an early checkpoint of one approach to preserving user defined blank spaces (between members). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=25125

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -13 lines) Patch
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 8 chunks +43 lines, -5 lines 2 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 8 chunks +35 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
FYI: this is a snapshot of where I was before the test sprint. It's very ...
7 years, 5 months ago (2013-07-17 21:16:53 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/19668003/diff/2001/pkg/analyzer_experimental/lib/src/services/formatter_impl.dart File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/19668003/diff/2001/pkg/analyzer_experimental/lib/src/services/formatter_impl.dart#newcode958 pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:958: /// Print a list of [nodes], preserving blanklines ...
7 years, 5 months ago (2013-07-17 21:25:08 UTC) #2
pquitslund
Thanks Brian! https://codereview.chromium.org/19668003/diff/2001/pkg/analyzer_experimental/lib/src/services/formatter_impl.dart File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/19668003/diff/2001/pkg/analyzer_experimental/lib/src/services/formatter_impl.dart#newcode958 pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:958: /// Print a list of [nodes], preserving ...
7 years, 5 months ago (2013-07-17 21:44:13 UTC) #3
pquitslund
7 years, 5 months ago (2013-07-17 21:44:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698