Issue 196653004: - Fix formatting of generated sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196653004: - Fix formatting of generated sources. (Closed)

Created:
6 years, 9 months ago by Ivan Posva

Modified:
6 years, 9 months ago

Reviewers:
hausner, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix formatting of generated sources. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=33570

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
	M	runtime/vm/object.cc	View		3 chunks	+13 lines, -1 line	0 comments	Download
	M	runtime/vm/object_test.cc	View		1 chunk	+34 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r33570 (presubmit successful).

6 years, 9 months ago (2014-03-12 09:16:28 UTC) #3

kasperl

6 years, 9 months ago (2014-03-12 09:20:17 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/196653004/diff/1/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/196653004/diff/1/runtime/vm/object_test.cc#ne...
runtime/vm/object_test.cc:204: "    } catch (e, s) {\n"
Also test that it works with finally? There was a missing space before that too.

Expand Messages | Collapse Messages