Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 19663011: Custom Syntax's are now enabled via template.bindingDelegate = (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Custom Syntax's are now enabled via template.bindingDelegate = port of https://github.com/Polymer/mdv/commit/d4c97a94fe565b07eec174ab27994e67a514ce4b (except the expression syntax bits -- that's covered in fancy_syntax) BUG= R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=25371

Patch Set 1 #

Total comments: 1

Patch Set 2 : restore @Experimental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -240 lines) Patch
M pkg/mdv/lib/mdv.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/mdv/lib/src/template.dart View 3 chunks +28 lines, -5 lines 0 comments Download
M pkg/mdv/lib/src/template_iterator.dart View 6 chunks +15 lines, -14 lines 0 comments Download
M pkg/mdv/test/binding_syntax_test.dart View 6 chunks +34 lines, -92 lines 0 comments Download
M pkg/mdv/test/element_bindings_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/mdv/test/mdv_test_utils.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/mdv/test/node_bindings_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/mdv/test/template_element_test.dart View 4 chunks +33 lines, -54 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +30 lines, -22 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +30 lines, -22 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +21 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 4 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
https://codereview.chromium.org/19663011/diff/1/sdk/lib/chrome/dart2js/chrome_dart2js.dart File sdk/lib/chrome/dart2js/chrome_dart2js.dart (right): https://codereview.chromium.org/19663011/diff/1/sdk/lib/chrome/dart2js/chrome_dart2js.dart#newcode7 sdk/lib/chrome/dart2js/chrome_dart2js.dart:7: /// http://developer.chrome.com/extensions/api_index.html I'm not sure why this file keeps ...
7 years, 5 months ago (2013-07-22 20:39:54 UTC) #1
justinfagnani
lgtm
7 years, 5 months ago (2013-07-23 21:37:41 UTC) #2
Jennifer Messerly
7 years, 5 months ago (2013-07-23 21:49:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698