Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 196603029: Fix test timeouts. I forgot to include observe/mirrors_used.dart in tests from (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix test timeouts. I forgot to include observe/mirrors_used.dart in tests from other packages. They got big enough that dart2js times out. Committed: https://code.google.com/p/dart/source/detail?r=33795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/polymer_expressions/test/bindings_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer_expressions/test/eval_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer_expressions/test/globals_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer_expressions/test/syntax_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/template_binding/test/node_bind_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/template_binding/test/template_binding_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
TBR
6 years, 9 months ago (2014-03-18 01:21:37 UTC) #1
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r33795 (presubmit successful).
6 years, 9 months ago (2014-03-18 01:21:53 UTC) #2
Jennifer Messerly
6 years, 9 months ago (2014-03-18 18:33:12 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698