Issue 196573040: Fixing e2e test in windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196573040: Fixing e2e test in windows (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing e2e test in windows R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34122

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	pkg/smoke/test/codegen/end_to_end_test.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/196573040/diff/20001/pkg/smoke/test/codegen/end_to_end_test.dart File pkg/smoke/test/codegen/end_to_end_test.dart (right): https://codereview.chromium.org/196573040/diff/20001/pkg/smoke/test/codegen/end_to_end_test.dart#newcode27 pkg/smoke/test/codegen/end_to_end_test.dart:27: var scriptPath = path.fromUri(Platform.script); after debugging on a windows ...

6 years, 9 months ago (2014-03-19 17:30:13 UTC) #1

Siggi Cherem (dart-lang)

6 years, 9 months ago (2014-03-19 17:52:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r34122 (presubmit successful).

Expand Messages | Collapse Messages

Issue 196573040: Fixing e2e test in windows (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages