Issue 196533015: Fix bug in trim introduced by rewrite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196533015: Fix bug in trim introduced by rewrite. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix bug in trim introduced by rewrite. Code worked in V8 because it treats NEL as whitespace (incorrectly), but failed in Firefox. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=33643

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	sdk/lib/_internal/lib/js_string.dart	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
	M	tests/corelib/string_trim2_test.dart	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

6 years, 9 months ago (2014-03-13 09:59:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33643 (presubmit successful).