Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 19653008: FIx a typo in SIMMIPS min/max and enable min_max_test for SIMMIPS by splitting the main functions i… (Closed)

Created:
7 years, 5 months ago by srdjan
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, zra, floitsch
Visibility:
Public.

Description

FIx a typo in SIMMIPS min/max and enable min_max_test for SIMMIPS by splitting the main functions into two parts. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/math/min_max_test.dart View 5 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 5 months ago (2013-07-22 22:24:30 UTC) #1
regis
LGTM
7 years, 5 months ago (2013-07-22 22:25:27 UTC) #2
srdjan
7 years, 5 months ago (2013-07-22 22:43:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698