Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 19653004: Add test for reusing the port of a server socket, after the server's close future is completed. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen
Modified:
7 years, 5 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test for reusing the port of a server socket, after the server's close future is completed. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=25257

Patch Set 1 #

Patch Set 2 : Add unclean close version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A tests/standalone/io/http_reuse_server_port_test.dart View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 5 months ago (2013-07-19 14:09:53 UTC) #1
kustermann
lgtm One comment: Your test does always wait until all client connections are gone before ...
7 years, 5 months ago (2013-07-19 15:36:22 UTC) #2
Anders Johnsen
Committed patchset #2 manually as r25257 (presubmit successful).
7 years, 5 months ago (2013-07-22 04:49:49 UTC) #3
Anders Johnsen
7 years, 5 months ago (2013-07-22 04:50:03 UTC) #4
Message was sent while issue was closed.
Added an unclean version.

Powered by Google App Engine
This is Rietveld 408576698