Clean up ClosureMirror.invoke(#call, ...).

Clean up ClosureMirror.invoke(#call, ...).

R=asiva@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33790

[Florian Schneider, 2014-03-13 08:14:18]

dbc:

https://codereview.chromium.org/196513004/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/196513004/diff/1/runtime/lib/mirrors_impl.dar...
runtime/lib/mirrors_impl.dart:463: //   return this.invoke(#call,
positionalArguments, namedArguments);
Functions now have a .call method for invocation.

[Florian Schneider, 2014-03-13 10:41:22]

On 2014/03/13 08:14:18, Florian Schneider wrote:
> dbc:
> 
> https://codereview.chromium.org/196513004/diff/1/runtime/lib/mirrors_impl.dart
> File runtime/lib/mirrors_impl.dart (right):
> 
>
https://codereview.chromium.org/196513004/diff/1/runtime/lib/mirrors_impl.dar...
> runtime/lib/mirrors_impl.dart:463: //   return this.invoke(#call,
> positionalArguments, namedArguments);
> Functions now have a .call method for invocation.

To be precise: They don't have a .call method that is discoverable like other
methods, but they
support invocation via .call method call.

[rmacnak, 2014-03-13 17:26:27]

On 2014/03/13 10:41:22, Florian Schneider wrote:
> On 2014/03/13 08:14:18, Florian Schneider wrote:
> > dbc:
> > 
> >
https://codereview.chromium.org/196513004/diff/1/runtime/lib/mirrors_impl.dart
> > File runtime/lib/mirrors_impl.dart (right):
> > 
> >
>
https://codereview.chromium.org/196513004/diff/1/runtime/lib/mirrors_impl.dar...
> > runtime/lib/mirrors_impl.dart:463: //   return this.invoke(#call,
> > positionalArguments, namedArguments);
> > Functions now have a .call method for invocation.
> 
> To be precise: They don't have a .call method that is discoverable like other
> methods, but they
> support invocation via .call method call.

It should be discoverable like other methods to remove the special cases here.
Probably the base-level implementation should be pushed down to the resolver,
which might automatically fix the problem that this method can't currently be
closurized.

[gbracha, 2014-03-13 18:30:22]

test lgtm

[rmacnak, 2014-03-17 20:23:48]

Adapted to the new implementation of closure.call. Just deletions now, modulo
the test :)

[siva, 2014-03-17 22:43:49]

lgtm

[rmacnak, 2014-03-17 23:43:37]

Committed patchset #2 manually as r33790 (presubmit successful).