Issue 196473016: Consider errors logged by a transformer equivalent to thrown errors.

Issue 196473016: Consider errors logged by a transformer equivalent to thrown errors. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Consider errors logged by a transformer equivalent to thrown errors. R=rnystrom@google.com BUG=15618 Committed: https://code.google.com/p/dart/source/detail?r=33674

Patch Set 2 : code review #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -22 lines)			Patch
M	pkg/barback/lib/src/base_transform.dart	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View	1	6 chunks	+22 lines, -9 lines	0 comments	Download
M	pkg/barback/test/package_graph/errors_test.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A +	pkg/barback/test/transformer/bad_log.dart	View		2 chunks	+9 lines, -13 lines	0 comments	Download
M	pkg/barback/test/utils.dart	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/196473016/diff/1/pkg/barback/lib/src/transform_node.dart File pkg/barback/lib/src/transform_node.dart (right): https://codereview.chromium.org/196473016/diff/1/pkg/barback/lib/src/transform_node.dart#newcode222 pkg/barback/lib/src/transform_node.dart:222: if (_state.needsIsPrimary) return null; Return false here. I ...

6 years, 9 months ago (2014-03-13 22:08:34 UTC) #2

nweiz

https://codereview.chromium.org/196473016/diff/1/pkg/barback/lib/src/transform_node.dart File pkg/barback/lib/src/transform_node.dart (right): https://codereview.chromium.org/196473016/diff/1/pkg/barback/lib/src/transform_node.dart#newcode222 pkg/barback/lib/src/transform_node.dart:222: if (_state.needsIsPrimary) return null; On 2014/03/13 22:08:35, Bob Nystrom ...

6 years, 9 months ago (2014-03-13 23:29:38 UTC) #3

nweiz

6 years, 9 months ago (2014-03-13 23:31:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33674 (presubmit successful).

Expand Messages | Collapse Messages