Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 19647015: Triage remaining co19 tests for VM. Update also dart2js and dart2dart status where applicable. (Closed)

Created:
7 years, 5 months ago by srdjan
Modified:
7 years, 5 months ago
Reviewers:
regis, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Triage remaining co19 tests for VM. Update also dart2js and dart2dart status where applicable. R=ahe@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25429

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -123 lines) Patch
M tests/co19/co19-dart2dart.status View 2 chunks +37 lines, -37 lines 0 comments Download
M tests/co19/co19-dart2js.status View 3 chunks +37 lines, -37 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 4 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
7 years, 5 months ago (2013-07-23 23:26:17 UTC) #1
regis
LGTM Thanks for doing this. https://codereview.chromium.org/19647015/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/19647015/diff/1/tests/co19/co19-runtime.status#newcode71 tests/co19/co19-runtime.status:71: LibTest/collection/Queue/iterator_A01_t01: Fail # BEING ...
7 years, 5 months ago (2013-07-23 23:35:42 UTC) #2
ahe
LGTM! Thank you, Srdjan!
7 years, 5 months ago (2013-07-24 10:09:23 UTC) #3
srdjan
https://codereview.chromium.org/19647015/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/19647015/diff/1/tests/co19/co19-runtime.status#newcode71 tests/co19/co19-runtime.status:71: LibTest/collection/Queue/iterator_A01_t01: Fail # BEING FIXED --- REMOVE On 2013/07/23 ...
7 years, 5 months ago (2013-07-24 15:21:32 UTC) #4
srdjan
7 years, 5 months ago (2013-07-24 17:43:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698