Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 19647002: Use PUB_HOSTED_SERVER to set server URL for pub tests. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, keertip
Visibility:
Public.

Description

Use PUB_HOSTED_SERVER to set server URL for pub tests. BUG=https://code.google.com/p/dart/issues/detail?id=11808 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=25118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 chunk +5 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/switch_source_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
I was hoping this would let us clean up more of the pub test code, ...
7 years, 5 months ago (2013-07-17 17:50:38 UTC) #1
nweiz
lgtm
7 years, 5 months ago (2013-07-17 18:27:21 UTC) #2
Bob Nystrom
7 years, 5 months ago (2013-07-17 18:43:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698