Add two argument shuffle operations to Float32x4

Add two argument shuffle operations to Float32x4

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25443

[Cutch, 2013-07-22 21:35:38]

Opinions on method names?

[zra, 2013-07-22 21:45:03]

On 2013/07/22 21:35:38, Cutch wrote:
> Opinions on method names?

The alternating cases of the letters threw me off a bit. Maybe e.g. withZWinXY
instead of withZwInXy?

[Cutch, 2013-07-22 22:33:44]

On 2013/07/22 21:45:03, zra wrote:
> On 2013/07/22 21:35:38, Cutch wrote:
> > Opinions on method names?
> 
> The alternating cases of the letters threw me off a bit. Maybe e.g. withZWinXY
> instead of withZwInXy?

Fixed. I had misread the Dart style guide. Acronyms only two letters can have
both letters be capitalized. Longer than three must use camel case, for example:
Ftp.

[srdjan, 2013-07-24 18:08:31]

lgtm

https://codereview.chromium.org/19646005/diff/4001/runtime/lib/simd128.cc
File runtime/lib/simd128.cc (right):

https://codereview.chromium.org/19646005/diff/4001/runtime/lib/simd128.cc#new...
runtime/lib/simd128.cc:245: DEFINE_NATIVE_ENTRY(Float32x4_withZwInXy, 2) {
I would sync the name style with Dart, as withZWInXY is more readable. Or you
could say: with_zw_in_xy. Your pick. If you decide to change it, sync other
names below as well.

[Cutch, 2013-07-24 21:20:18]

https://codereview.chromium.org/19646005/diff/4001/runtime/lib/simd128.cc
File runtime/lib/simd128.cc (right):

https://codereview.chromium.org/19646005/diff/4001/runtime/lib/simd128.cc#new...
runtime/lib/simd128.cc:245: DEFINE_NATIVE_ENTRY(Float32x4_withZwInXy, 2) {
On 2013/07/24 18:08:31, srdjan wrote:
> I would sync the name style with Dart, as withZWInXY is more readable. Or you
> could say: with_zw_in_xy. Your pick. If you decide to change it, sync other
> names below as well.

Done.

[Cutch, 2013-07-24 21:29:52]

Committed patchset #3 manually as r25443 (presubmit successful).