- First step in refactoring ports with the goal of moving

- First step in refactoring ports with the goal of moving
  them closer into the VM implementation.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34438

[siva, 2014-03-25 23:42:51]

lgtm

https://codereview.chromium.org/196443009/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/196443009/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:1197: port_instance ^= Api::UnwrapHandle(port);
Maybe you should use:

const Instance& port_instance = Api::UnwrapInstanceHandle(isolate, port);
if (port_instance.IsNull()) {
  RETURN_TYPE_ERROR(isolate, port, Instance);
}

That way you return an error if invalid objects are passed in for 'port'. This
pattern is used in other functions.

https://codereview.chromium.org/196443009/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:1204: ASSERT(!idObj.IsError());
ASSERT(idObj.IsInteger());
const Integer id = Integer::Cast(idObj);

[Ivan Posva, 2014-03-26 17:17:31]

Thanks,
-Ivan

https://codereview.chromium.org/196443009/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/196443009/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:1197: port_instance ^= Api::UnwrapHandle(port);
On 2014/03/25 23:42:51, siva wrote:
> Maybe you should use:
> 
> const Instance& port_instance = Api::UnwrapInstanceHandle(isolate, port);
> if (port_instance.IsNull()) {
>   RETURN_TYPE_ERROR(isolate, port, Instance);
> }
> 
> That way you return an error if invalid objects are passed in for 'port'. This
> pattern is used in other functions.

Done.

https://codereview.chromium.org/196443009/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:1204: ASSERT(!idObj.IsError());
On 2014/03/25 23:42:51, siva wrote:
> ASSERT(idObj.IsInteger());
> const Integer id = Integer::Cast(idObj);

Done.

[Ivan Posva, 2014-03-26 17:30:45]

Committed patchset #2 manually as r34438 (presubmit successful).