Issue 196413005: Make zone variables accept any value as key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196413005: Make zone variables accept any value as key. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -39 lines)			Patch
	M	sdk/lib/async/zone.dart	View		11 chunks	+25 lines, -15 lines	0 comments	Download
	M	tests/lib/async/zone_value_test.dart	View	1	1 chunk	+118 lines, -24 lines	0 comments	Download

Total messages: 5 (0 generated)

floitsch

LGTM so far. Ask me for another look when the tests are there, please. (Not ...

6 years, 9 months ago (2014-03-12 15:53:00 UTC) #2

Lasse Reichstein Nielsen

6 years, 9 months ago (2014-03-21 13:30:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r34248 (presubmit successful).