Issue 19638009: "Reverting 25160"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19638009: "Reverting 25160" (Closed)

Created:
7 years, 5 months ago by janicejl

Modified:
7 years, 5 months ago

Reviewers:
Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

"Reverting 25160" BUG= Committed: https://code.google.com/p/dart/source/detail?r=25163

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -48 lines)			Patch
	M	pkg/docgen/lib/docgen.dart	View		5 chunks	+19 lines, -43 lines	1 comment	Download
	M	pkg/docgen/test/single_library_test.dart	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

janicejl

Committed patchset #1 manually as r25163 (presubmit successful).

7 years, 5 months ago (2013-07-18 18:32:39 UTC) #2

Emily Fortuna

7 years, 5 months ago (2013-07-18 18:33:34 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/19638009/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (left):

https://codereview.chromium.org/19638009/diff/1/pkg/docgen/lib/docgen.dart#ol...
pkg/docgen/lib/docgen.dart:397: 'abstract': abstract,
abstract is a reserved word (for "abstract class" etc). just rename these
variables and you shouldn't need to revert.

Expand Messages | Collapse Messages