Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 19638002: Remove explicit argument type checks in math min and max. (Closed)

Created:
7 years, 5 months ago by srdjan
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove explicit argument type checks in math min and max. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=25112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -48 lines) Patch
M sdk/lib/math/math.dart View 2 chunks +32 lines, -48 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 5 months ago (2013-07-17 17:00:50 UTC) #1
floitsch
LGTM.
7 years, 5 months ago (2013-07-17 18:06:14 UTC) #2
srdjan
7 years, 5 months ago (2013-07-17 18:15:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698