Issue 196353012: VM: Fix infinite recursion in optimization of of string interpolation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196353012: VM: Fix infinite recursion in optimization of of string interpolation. (Closed)

Created:
6 years, 9 months ago by Florian Schneider

Modified:
6 years, 9 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix infinite recursion in optimization of of string interpolation. Don't compile-time fold string interpolation when compiling the interpolation function itself. This would otherwise case an infiniti recursion. Also check he result of calling the interpolation function before casting to a String. BUG=dartbug.com/17461 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33651

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #2 manually as r33651 (presubmit successful).

6 years, 9 months ago (2014-03-13 14:28:11 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages