Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1963283002: Fix parameter types for compareTo(). (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
Leaf, Chris Bracken
CC:
reviews_dartlang.org, Chris Bracken, sra
Base URL:
https://github.com/dart-lang/fixnum@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix parameter types for compareTo(). Also adding a CHANGELOG and analysis_options since it's strong mode clean now. R=cbracken@google.com, leafp@google.com Committed: https://github.com/dart-lang/fixnum/commit/2d95f7d21690be6f077128f6bd5c29d875f71fee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/int32.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/int64.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/intx.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
Chris, I was initially going to just roll your fix into the external repo, but ...
4 years, 7 months ago (2016-05-10 21:02:57 UTC) #2
Chris Bracken
lgtm
4 years, 7 months ago (2016-05-10 21:22:36 UTC) #4
Leaf
lgtm
4 years, 7 months ago (2016-05-10 21:30:49 UTC) #5
Bob Nystrom
4 years, 7 months ago (2016-05-10 21:48:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d95f7d21690be6f077128f6bd5c29d875f71fee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698