Issue 19627004: Add echo and line modes to Stdin.

Issue 19627004: Add echo and line modes to Stdin. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add echo and line modes to Stdin. BUG=https://code.google.com/p/dart/issues/detail?id=8190,https://code.google.com/p/dart/issues/detail?id=9825,https://code.google.com/p/dart/issues/detail?id=11659 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25413

Patch Set 1 #

Patch Set 2 : Add missing files. #

Total comments: 6

Patch Set 3 : Clean up linux impl #

Patch Set 4 : Add Windows impl. #

Patch Set 5 : Remove outcommented line. #

Patch Set 6 : Add missing windows file. #

Patch Set 7 : Add macos and android version. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+326 lines, -52 lines)			Patch
M	runtime/bin/io_impl_sources.gypi	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/io_natives.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	runtime/bin/stdin.h	View	1 2	1 chunk	+16 lines, -15 lines	0 comments	Download
M	runtime/bin/stdin.cc	View	1 2	2 chunks	+20 lines, -6 lines	0 comments	Download
A	runtime/bin/stdin_android.cc	View	1 2 3 4 5 6	1 chunk	+52 lines, -0 lines	0 comments	Download
A	runtime/bin/stdin_linux.cc	View	1 2	1 chunk	+52 lines, -0 lines	0 comments	Download
A	runtime/bin/stdin_macos.cc	View	1 2 3 4 5 6	1 chunk	+52 lines, -0 lines	0 comments	Download
A	runtime/bin/stdin_win.cc	View	1 2 3 4 5 6	1 chunk	+54 lines, -0 lines	0 comments	Download
M	runtime/bin/stdio_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/io/stdio.dart	View		2 chunks	+20 lines, -1 line	0 comments	Download
M	tests/standalone/io/stdin_sync_test.dart	View	1 2 3	1 chunk	+51 lines, -30 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Please take a look before I port it to other platforms.

7 years, 5 months ago (2013-07-24 12:07:48 UTC) #1

Søren Gjesse

Looks good - please go ahead https://codereview.chromium.org/19627004/diff/3001/runtime/bin/stdin.h File runtime/bin/stdin.h (right): https://codereview.chromium.org/19627004/diff/3001/runtime/bin/stdin.h#newcode20 runtime/bin/stdin.h:20: static void setEchoMode(bool ...

7 years, 5 months ago (2013-07-24 12:18:49 UTC) #2

Anders Johnsen

https://codereview.chromium.org/19627004/diff/3001/runtime/bin/stdin.h File runtime/bin/stdin.h (right): https://codereview.chromium.org/19627004/diff/3001/runtime/bin/stdin.h#newcode20 runtime/bin/stdin.h:20: static void setEchoMode(bool enabled); On 2013/07/24 12:18:49, Søren Gjesse ...

7 years, 5 months ago (2013-07-24 12:57:49 UTC) #3

Anders Johnsen

7 years, 5 months ago (2013-07-24 13:52:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #7 manually as r25413 (presubmit successful).

Expand Messages | Collapse Messages