Issue 196243002: Use CHECK_ISOLATE instead of DARTSCOPE for Dart_GetNativeInstanceField after

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196243002: Use CHECK_ISOLATE instead of DARTSCOPE for Dart_GetNativeInstanceField after (Closed)

Created:
6 years, 9 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use CHECK_ISOLATE instead of DARTSCOPE for Dart_GetNativeInstanceField after fixing Instance::IsValidFieldOffset to use a reusable handle instead of creating a new one (this was the issue last time which caused assertions). R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=33566

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/object.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

6 years, 9 months ago (2014-03-12 00:14:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33566 (presubmit successful).

Expand Messages | Collapse Messages