New verbose flag for the dart command line analyzer

New verbose flag for the dart command line analyzer

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33656

[jwren, 2014-03-12 17:40:01]

https://codereview.chromium.org/196223004/diff/1/pkg/analyzer/lib/options.dart
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/196223004/diff/1/pkg/analyzer/lib/options.dar...
pkg/analyzer/lib/options.dart:55: final bool verbose;
Any other suggestions other than "verbose"?  Brian suggested "debug", but that
is used by the VM.  The other command line tools tend to use "verbose" which is
why I fell back to it, but I am open.

[scheglov, 2014-03-12 19:07:01]

lgtm

https://codereview.chromium.org/196223004/diff/1/pkg/analyzer/lib/options.dart
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/196223004/diff/1/pkg/analyzer/lib/options.dar...
pkg/analyzer/lib/options.dart:55: final bool verbose;
On 2014/03/12 17:40:01, jwren wrote:
> Any other suggestions other than "verbose"?  Brian suggested "debug", but that
> is used by the VM.  The other command line tools tend to use "verbose" which
is
> why I fell back to it, but I am open.

"verbose" sounds good to me.

[Brian Wilkerson, 2014-03-12 19:17:08]

I still don't think "verbose" is the right flag (see e-mail thread).

[jwren, 2014-03-13 16:38:26]

On 2014/03/12 19:17:08, Brian Wilkerson wrote:
> I still don't think "verbose" is the right flag (see e-mail thread).

Updated:
- 'verbose' -> 'log'
- Failing messages are now always printed out now, additional messages are
printed when --log is included
- The --log flag will not be shown when the --help flag is passed.

[Brian Wilkerson, 2014-03-13 16:51:23]

LGTM

[jwren, 2014-03-13 17:13:13]

Committed patchset #2 manually as r33656 (presubmit successful).