Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 196213005: Enable cross compiled outputs in the testing scripts (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Bill Hesse, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable cross compiled outputs in the testing scripts R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33650

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M tools/testing/dart/test_suite.dart View 2 chunks +22 lines, -10 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
6 years, 9 months ago (2014-03-13 10:42:05 UTC) #1
ricow1
6 years, 9 months ago (2014-03-13 11:51:42 UTC) #2
Bill Hesse
LGTM. https://codereview.chromium.org/196213005/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/196213005/diff/1/tools/testing/dart/test_suite.dart#newcode2085 tools/testing/dart/test_suite.dart:2085: if (normalDir.existsSync() && crossDir.existsSync()) { Why not if ...
6 years, 9 months ago (2014-03-13 11:59:38 UTC) #3
ricow1
https://codereview.chromium.org/196213005/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/196213005/diff/1/tools/testing/dart/test_suite.dart#newcode2085 tools/testing/dart/test_suite.dart:2085: if (normalDir.existsSync() && crossDir.existsSync()) { On 2014/03/13 11:59:39, Bill ...
6 years, 9 months ago (2014-03-13 12:04:39 UTC) #4
ricow1
Committed patchset #1 manually as r33650 (presubmit successful).
6 years, 9 months ago (2014-03-13 12:04:53 UTC) #5
Ivan Posva
6 years, 9 months ago (2014-03-13 12:11:27 UTC) #6
Message was sent while issue was closed.
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698