pkg/docgen: more cleanup

pkg/docgen: more cleanup

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33769

[Emily Fortuna, 2014-03-17 17:54:31]

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:561: var f = new Uri.file(path.absolute(arg));
I dislike single letter variable names outside of for loops.

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/test/generate_jso...
File pkg/docgen/test/generate_json_test.dart (right):

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/test/generate_jso...
pkg/docgen/test/generate_json_test.dart:35: return dg.docgen([codeDir], out:
p.join(d.defaultRoot, 'docs'));
have you actually run this test? Dart2js throws an error if that directory
doesn't end in a slash (yeah... take it up with the dart2js folk)

[Alan Knight, 2014-03-17 17:58:06]

lgtm

[kevmoo, 2014-03-17 20:13:02]

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:561: var f = new Uri.file(path.absolute(arg));
On 2014/03/17 17:54:31, Emily Fortuna wrote:
> I dislike single letter variable names outside of for loops. 

Done.

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/test/generate_jso...
File pkg/docgen/test/generate_json_test.dart (right):

https://codereview.chromium.org/196133023/diff/1/pkg/docgen/test/generate_jso...
pkg/docgen/test/generate_json_test.dart:35: return dg.docgen([codeDir], out:
p.join(d.defaultRoot, 'docs'));
On 2014/03/17 17:54:31, Emily Fortuna wrote:
> have you actually run this test? Dart2js throws an error if that directory
> doesn't end in a slash (yeah... take it up with the dart2js folk)

Tests run fine. Do these tests run in dart2js?

[kevmoo, 2014-03-17 20:20:26]

On 2014/03/17 20:13:02, kevmoo wrote:
> https://codereview.chromium.org/196133023/diff/1/pkg/docgen/lib/docgen.dart
> File pkg/docgen/lib/docgen.dart (right):
> 
>
https://codereview.chromium.org/196133023/diff/1/pkg/docgen/lib/docgen.dart#n...
> pkg/docgen/lib/docgen.dart:561: var f = new Uri.file(path.absolute(arg));
> On 2014/03/17 17:54:31, Emily Fortuna wrote:
> > I dislike single letter variable names outside of for loops. 
> 
> Done.
> 
>
https://codereview.chromium.org/196133023/diff/1/pkg/docgen/test/generate_jso...
> File pkg/docgen/test/generate_json_test.dart (right):
> 
>
https://codereview.chromium.org/196133023/diff/1/pkg/docgen/test/generate_jso...
> pkg/docgen/test/generate_json_test.dart:35: return dg.docgen([codeDir], out:
> p.join(d.defaultRoot, 'docs'));
> On 2014/03/17 17:54:31, Emily Fortuna wrote:
> > have you actually run this test? Dart2js throws an error if that directory
> > doesn't end in a slash (yeah... take it up with the dart2js folk)
> 
> Tests run fine. Do these tests run in dart2js?

I verified the output is good and ran these tests. I think we're good

./tools/test.py -m release pkg/docgen -r none,vm,jsshell -c
none,dart2js,dartanalyzer --checked --progress verbose
Warning: combination of compiler 'none' and runtime 'none' is invalid. Skipping
this combination.
Warning: combination of compiler 'none' and runtime 'jsshell' is invalid.
Skipping this combination.
Warning: combination of compiler 'dart2js' and runtime 'vm' is invalid. Skipping
this combination.
Warning: combination of compiler 'dartanalyzer' and runtime 'vm' is invalid.
Skipping this combination.
Warning: combination of compiler 'dartanalyzer' and runtime 'jsshell' is
invalid. Skipping this combination.
Test configurations: none_vm_release_ia32_checked
dart2js_none_release_ia32_checked dart2js_jsshell_release_ia32_checked
dartanalyzer_none_release_ia32_checked
Done none-vm-checked release_ia32 pkg/docgen/test/multi_library_test: pass
Done none-vm-checked release_ia32 pkg/docgen/test/single_library_test: pass
Done dartanalyzer-none-checked release_ia32 pkg/docgen/test/generate_json_test:
pass
Done dartanalyzer-none-checked release_ia32 pkg/docgen/test/multi_library_test:
pass
Done none-vm-checked release_ia32 pkg/docgen/test/generate_json_test: pass
Done dartanalyzer-none-checked release_ia32 pkg/docgen/test/single_library_test:
pass
Done dart2js-none-checked release_ia32 pkg/docgen/test/single_library_test: pass
Done dart2js-jsshell-checked release_ia32 pkg/docgen/test/single_library_test:
pass
Done dart2js-none-checked release_ia32 pkg/docgen/test/generate_json_test: pass
Done dart2js-jsshell-checked release_ia32 pkg/docgen/test/generate_json_test:
pass
Done dart2js-none-checked release_ia32 pkg/docgen/test/multi_library_test: pass
Done dart2js-jsshell-checked release_ia32 pkg/docgen/test/multi_library_test:
pass

[kevmoo, 2014-03-17 20:21:28]

Committed patchset #2 manually as r33769 (presubmit successful).