Move dart2js entrypoint detection into isPrimary.

Move dart2js entrypoint detection into isPrimary.

With https://codereview.chromium.org/196273003/, it matters less that
isPrimary be as efficient as possible. This will also improve
logging (see issue 17422) and make the lazy pipeline more accurate.

R=rnystrom@google.com
BUG=17422
Committed: https://code.google.com/p/dart/source/detail?r=33620

[Bob Nystrom, 2014-03-12 18:08:25]

lgtm

[nweiz, 2014-03-12 20:41:25]

I realized that this was causing some of pub's error-validation tests to fail. I
ended up making it so that if the analyzer detects a syntax error, it reports
the file as primary. This has two benefits: first, it means that we get
dart2js's error reports, which are generally more detailed. Second, it means
that when using pub serve, syntax errors are only reported when the user
requests the file in question.

Anyway, PTAL

[Bob Nystrom, 2014-03-12 21:12:25]

LGTM!

https://codereview.chromium.org/196063004/diff/20001/pkg/scheduled_test/lib/s...
File pkg/scheduled_test/lib/src/stream_matcher.dart (right):

https://codereview.chromium.org/196063004/diff/20001/pkg/scheduled_test/lib/s...
pkg/scheduled_test/lib/src/stream_matcher.dart:26: StreamMatcher();
Is this needed?

https://codereview.chromium.org/196063004/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right):

https://codereview.chromium.org/196063004/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:60: /// Only
".dart" entrpoiny files within a buildable directory are processed.
"entrypoint".

[nweiz, 2014-03-12 21:49:06]

https://codereview.chromium.org/196063004/diff/20001/pkg/scheduled_test/lib/s...
File pkg/scheduled_test/lib/src/stream_matcher.dart (right):

https://codereview.chromium.org/196063004/diff/20001/pkg/scheduled_test/lib/s...
pkg/scheduled_test/lib/src/stream_matcher.dart:26: StreamMatcher();
On 2014/03/12 21:12:25, Bob Nystrom wrote:
> Is this needed?

Since the matchers now extend rather than implement, they need some superclass
constructor to implicitly call.

https://codereview.chromium.org/196063004/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right):

https://codereview.chromium.org/196063004/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:60: /// Only
".dart" entrpoiny files within a buildable directory are processed.
On 2014/03/12 21:12:25, Bob Nystrom wrote:
> "entrypoint".

Done.

[nweiz, 2014-03-12 21:52:22]

Committed patchset #2 manually as r33620 (presubmit successful).