Issue 19604004: Introduce an abstract DeclarationMirror in the implementation hierarchy; add a MirrorReference refl…

Issue 19604004: Introduce an abstract DeclarationMirror in the implementation hierarchy; add a MirrorReference refl… (Closed)

Created:
7 years, 5 months ago by rmacnak

Modified:
7 years, 5 months ago

Reviewers:
ahe, siva, Ivan Posva

CC:
reviews_dartlang.org, Michael Lippautz (Google), ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Introduce an abstract DeclarationMirror in the implementation hierarchy; add a MirrorReference reflectee to TypedefMirror and TypeVariableMirror. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25187

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -34 lines)			Patch
	M	runtime/lib/mirrors.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	runtime/lib/mirrors_impl.dart	View	1 2	10 chunks	+34 lines, -34 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/19604004/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/19604004/diff/1/runtime/lib/mirrors_impl.dart#newcode637 runtime/lib/mirrors_impl.dart:637: // get the metadata objects, convert them into ...

7 years, 5 months ago (2013-07-18 20:46:15 UTC) #2

rmacnak

https://codereview.chromium.org/19604004/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/19604004/diff/1/runtime/lib/mirrors_impl.dart#newcode639 runtime/lib/mirrors_impl.dart:639: return _metadata(_reflectee).map(reflect).toList(); On 2013/07/18 20:46:15, siva wrote: > toList(false) ...

7 years, 5 months ago (2013-07-18 21:04:50 UTC) #3

Ivan Posva

DBC -ip https://codereview.chromium.org/19604004/diff/6001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/19604004/diff/6001/runtime/lib/mirrors_impl.dart#newcode663 runtime/lib/mirrors_impl.dart:663: super(reflectee); Fits on one line. https://codereview.chromium.org/19604004/diff/6001/runtime/lib/mirrors_impl.dart#newcode716 runtime/lib/mirrors_impl.dart:716: ...

7 years, 5 months ago (2013-07-18 21:10:23 UTC) #4

ahe

FYI https://codereview.chromium.org/19604004/diff/6001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/19604004/diff/6001/runtime/lib/mirrors_impl.dart#newcode663 runtime/lib/mirrors_impl.dart:663: super(reflectee); On 2013/07/18 21:10:24, Ivan Posva wrote: > ...

7 years, 5 months ago (2013-07-18 21:26:31 UTC) #5

rmacnak

7 years, 5 months ago (2013-07-18 22:13:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r25187 (presubmit successful).

Expand Messages | Collapse Messages