Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 195993005: Don't pass an asset through a transformer that produces an error. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't pass an asset through a transformer that produces an error. R=rnystrom@google.com BUG=17415 Committed: https://code.google.com/p/dart/source/detail?r=33661

Patch Set 1 #

Total comments: 2

Patch Set 2 : move more tests into collisions_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -329 lines) Patch
M pkg/barback/lib/src/transform_node.dart View 4 chunks +7 lines, -11 lines 0 comments Download
A + pkg/barback/test/package_graph/collisions_test.dart View 1 1 chunk +0 lines, -133 lines 0 comments Download
M pkg/barback/test/package_graph/errors_test.dart View 1 2 chunks +4 lines, -185 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 9 months ago (2014-03-13 00:44:12 UTC) #1
Bob Nystrom
https://codereview.chromium.org/195993005/diff/1/pkg/barback/test/package_graph/collisions_test.dart File pkg/barback/test/package_graph/collisions_test.dart (left): https://codereview.chromium.org/195993005/diff/1/pkg/barback/test/package_graph/collisions_test.dart#oldcode15 pkg/barback/test/package_graph/collisions_test.dart:15: test("errors if two transformers output the same file", () ...
6 years, 9 months ago (2014-03-13 16:56:46 UTC) #2
nweiz
https://codereview.chromium.org/195993005/diff/1/pkg/barback/test/package_graph/collisions_test.dart File pkg/barback/test/package_graph/collisions_test.dart (left): https://codereview.chromium.org/195993005/diff/1/pkg/barback/test/package_graph/collisions_test.dart#oldcode15 pkg/barback/test/package_graph/collisions_test.dart:15: test("errors if two transformers output the same file", () ...
6 years, 9 months ago (2014-03-13 19:31:37 UTC) #3
Bob Nystrom
On 2014/03/13 19:31:37, nweiz wrote: > https://codereview.chromium.org/195993005/diff/1/pkg/barback/test/package_graph/collisions_test.dart > File pkg/barback/test/package_graph/collisions_test.dart (left): > > https://codereview.chromium.org/195993005/diff/1/pkg/barback/test/package_graph/collisions_test.dart#oldcode15 > ...
6 years, 9 months ago (2014-03-13 19:50:35 UTC) #4
nweiz
6 years, 9 months ago (2014-03-13 20:14:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r33661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698