Issue 19599007: Implement reflection on native classes.

Issue 19599007: Implement reflection on native classes. (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement reflection on native classes. BUG=http://dartbug.com/11902 R=karlklose@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25201

Patch Set 2 : Mark test as failing on VM (requires browser) #

Total comments: 4

Patch Set 3 : Address comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -16 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	4 chunks	+22 lines, -9 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	1 2	1 chunk	+4 lines, -7 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/lib/mirrors/native_class_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/19599007/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart (right): https://codereview.chromium.org/19599007/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart#newcode238 dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:238: jsAst.Expression init = This expression is no longer ...

7 years, 5 months ago (2013-07-19 09:29:40 UTC) #2

ngeoffray

https://codereview.chromium.org/19599007/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/19599007/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1865 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1865: if (emitClassFields(classElement, staticsBuilder, '', emitStatics: true)) { I don't ...

7 years, 5 months ago (2013-07-19 09:37:40 UTC) #3

ahe

Thank you, Karl and Nicolas! https://codereview.chromium.org/19599007/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/19599007/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1865 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1865: if (emitClassFields(classElement, staticsBuilder, '', ...

7 years, 5 months ago (2013-07-19 10:00:00 UTC) #4

ahe

7 years, 5 months ago (2013-07-19 10:07:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r25201 (presubmit successful).

Expand Messages | Collapse Messages