Issue 19596008: Implement correct back-throttleing for web-sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19596008: Implement correct back-throttleing for web-sockets. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement correct back-throttleing for web-sockets. This makes it possible to implement a simpler version of web_socket_ping_test, that doesn't have to involve timers. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25425

Patch Set 1 #

Patch Set 2 : Fix comment #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -18 lines)			Patch
M	sdk/lib/io/websocket.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View		8 chunks	+23 lines, -6 lines	0 comments	Download
M	tests/standalone/io/web_socket_ping_test.dart	View		1 chunk	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

TBR'ing as buildbot is read. Please do comment, as I'd be happy to address any ...

7 years, 5 months ago (2013-07-24 17:15:41 UTC) #2

Anders Johnsen

Committed patchset #2 manually as r25425 (presubmit successful).

7 years, 5 months ago (2013-07-24 17:16:06 UTC) #3

Message was sent while issue was closed.

Not commenting as this was reverted

Expand Messages | Collapse Messages