Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1959433002: Fix all strong-mode errors and warnings. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom
Base URL:
git@github.com:dart-lang/web_socket_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/html.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/io.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/channel.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/html_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M test/web_socket_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 7 months ago (2016-05-05 19:41:26 UTC) #1
Alan Knight
lgtm
4 years, 7 months ago (2016-05-09 17:56:47 UTC) #2
nweiz
4 years, 7 months ago (2016-05-09 19:09:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
021db10644347f21b8d0056d5d15963ec6a9fa93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698