Issue 19593010: Add UTF-8 encoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19593010: Add UTF-8 encoder. (Closed)

Created:
7 years, 5 months ago by floitsch

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add UTF-8 encoder. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25342

Patch Set 2 : Add empty string test. #

Total comments: 2

Patch Set 3 : Address comment. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+197 lines, -3 lines)			Patch
M	sdk/lib/convert/convert.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/convert/utf.dart	View	1 2	1 chunk	+114 lines, -2 lines	0 comments	Download
A	tests/lib/convert/utf8_encode_test.dart	View	1	1 chunk	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/19593010/diff/2001/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/19593010/diff/2001/sdk/lib/convert/utf.dart#newcode104 sdk/lib/convert/utf.dart:104: int byteIndex = _bufferIndex; Why this local variable?

7 years, 5 months ago (2013-07-23 14:22:47 UTC) #2

floitsch

https://codereview.chromium.org/19593010/diff/2001/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/19593010/diff/2001/sdk/lib/convert/utf.dart#newcode104 sdk/lib/convert/utf.dart:104: int byteIndex = _bufferIndex; On 2013/07/23 14:22:47, Søren Gjesse ...

7 years, 5 months ago (2013-07-23 14:41:07 UTC) #3