Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 19593006: [mdv] Implement two-way binding to HTMLTextArea.value (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -642 lines) Patch
M pkg/mdv/lib/mdv.dart View 2 chunks +5 lines, -1 line 0 comments Download
D pkg/mdv/lib/src/bindings.dart View 1 chunk +0 lines, -430 lines 0 comments Download
A pkg/mdv/lib/src/input_bindings.dart View 1 chunk +189 lines, -0 lines 2 comments Download
M pkg/mdv/lib/src/input_element.dart View 3 chunks +5 lines, -81 lines 0 comments Download
M pkg/mdv/lib/src/select_element.dart View 2 chunks +2 lines, -57 lines 0 comments Download
A + pkg/mdv/lib/src/template_iterator.dart View 1 chunk +0 lines, -59 lines 0 comments Download
A pkg/mdv/lib/src/text_area_element.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/mdv/test/node_bindings_test.dart View 1 chunk +18 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
(Note, this is based on another CL https://codereview.chromium.org/19771010/) https://codereview.chromium.org/19593006/diff/1/pkg/mdv/lib/src/input_bindings.dart File pkg/mdv/lib/src/input_bindings.dart (right): https://codereview.chromium.org/19593006/diff/1/pkg/mdv/lib/src/input_bindings.dart#newcode5 pkg/mdv/lib/src/input_bindings.dart:5: part ...
7 years, 5 months ago (2013-07-19 21:57:52 UTC) #1
justinfagnani
lgtm
7 years, 5 months ago (2013-07-19 22:02:32 UTC) #2
Jennifer Messerly
7 years, 5 months ago (2013-07-23 03:09:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698