Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 19592015: Get rid of hokey dependencyMapList stuff. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of hokey dependencyMapList stuff. Now that hosted deps in tests can be just like they are in normal pubspecs since the server URL is in an env var, we can simplify the tests. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=25305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -230 lines) Patch
M sdk/lib/_internal/pub/test/deploy/compiles_dart_entrypoints_to_dart_and_js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/copies_browser_js_next_to_entrypoints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/copies_non_dart_files_to_deploy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/ignores_non_entrypoint_dart_files_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/reports_dart_parse_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/deploy/with_no_web_directory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor.dart View 3 chunks +8 lines, -18 lines 0 comments Download
M sdk/lib/_internal/pub/test/dev_dependency_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/offline_test.dart View 3 chunks +6 lines, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_dependency_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_transitive_dependency_test.dart View 2 chunks +12 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart View 2 chunks +14 lines, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/broken_symlink_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_and_update_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_branch_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_revision_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_transitive_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_twice_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_with_trailing_slash_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/lock_version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/require_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/git/stay_locked_if_compatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/unlock_if_incompatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/cached_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/do_not_update_on_removed_constraints_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/install_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/install_transitive_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/repair_cache_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/resolve_constraints_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_compatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/unlock_if_incompatible_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_path_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_symlink_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_test.dart View 3 chunks +18 lines, -18 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/relative_symlink_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/switch_source_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/package_files_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_cache_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +3 lines, -47 lines 0 comments Download
M sdk/lib/_internal/pub/test/unknown_source_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_locked_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_one_locked_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_to_incompatible_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/unlock_dependers_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/unlock_if_necessary_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/update_removed_constraints_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/validator/dependency_test.dart View 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
7 years, 5 months ago (2013-07-19 21:51:08 UTC) #1
nweiz
I'm not a huge fan of how this makes the non-hosted dependency specifications more verbose, ...
7 years, 5 months ago (2013-07-19 22:45:28 UTC) #2
Bob Nystrom
On 2013/07/19 22:45:28, nweiz wrote: > I'm not a huge fan of how this makes ...
7 years, 5 months ago (2013-07-22 20:02:56 UTC) #3
nweiz
lgtm
7 years, 5 months ago (2013-07-22 20:32:00 UTC) #4
Bob Nystrom
7 years, 5 months ago (2013-07-22 21:09:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r25305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698