Issue 19590007: [mdv] template.ref must recursive to find the original source template

Issue 19590007: [mdv] template.ref must recursive to find the original source template (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly

Modified:
7 years, 5 months ago

Reviewers:
justinfagnani

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[mdv] template.ref must recursive to find the original source template port of https://github.com/Polymer/mdv/commit/86040735c2973c8cc078677e3dabb56b5bfc70c0 R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=25327

Patch Set 2 : revert file generated by dom.py #

Total comments: 4

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -10 lines)			Patch
M	pkg/mdv/lib/src/template.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/mdv/test/template_element_test.dart	View	1 chunk	+15 lines, -0 lines	4 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

note, this is based on: https://codereview.chromium.org/19771010/

7 years, 5 months ago (2013-07-19 20:27:02 UTC) #1

justinfagnani

lgtm https://codereview.chromium.org/19590007/diff/2001/pkg/mdv/test/template_element_test.dart File pkg/mdv/test/template_element_test.dart (right): https://codereview.chromium.org/19590007/diff/2001/pkg/mdv/test/template_element_test.dart#newcode1354 pkg/mdv/test/template_element_test.dart:1354: '<template bind>' + no need for +s https://codereview.chromium.org/19590007/diff/2001/pkg/mdv/test/template_element_test.dart#newcode1359 ...

7 years, 5 months ago (2013-07-19 22:11:09 UTC) #2

Jennifer Messerly

https://codereview.chromium.org/19590007/diff/2001/pkg/mdv/test/template_element_test.dart File pkg/mdv/test/template_element_test.dart (right): https://codereview.chromium.org/19590007/diff/2001/pkg/mdv/test/template_element_test.dart#newcode1354 pkg/mdv/test/template_element_test.dart:1354: '<template bind>' + On 2013/07/19 22:11:09, justinfagnani wrote: > ...

7 years, 5 months ago (2013-07-23 02:51:31 UTC) #3

Jennifer Messerly

7 years, 5 months ago (2013-07-23 03:08:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25327 (presubmit successful).

Expand Messages | Collapse Messages