Issue 195893036: Revert the removal of some status file lines for unchecked dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195893036: Revert the removal of some status file lines for unchecked dartium. (Closed)

Created:
6 years, 9 months ago by Bill Hesse

Modified:
6 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert the removal of some status file lines for unchecked dartium. The lines were removed in r33807. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=33814

Patch Set 2 : address comment. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	tests/language/language.status	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

The lines were removed in r33807, but are actually needed.

6 years, 9 months ago (2014-03-18 16:59:34 UTC) #1

ahe

Conditional LGTM https://codereview.chromium.org/195893036/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/195893036/diff/1/tests/language/language.status#newcode93 tests/language/language.status:93: named_parameters_type_test/01: Fail # Issue 13719: Please triage ...

6 years, 9 months ago (2014-03-18 17:01:25 UTC) #2

Bill Hesse

6 years, 9 months ago (2014-03-18 17:16:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33814 (presubmit successful).

Expand Messages | Collapse Messages

Issue 195893036: Revert the removal of some status file lines for unchecked dartium. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address comment. #

Messages