Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 195893012: Use a sync-writing StreamConsumer for stdout/stderr. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva, dgrove, Bob Nystrom, nweiz
Visibility:
Public.

Description

Use a sync-writing StreamConsumer for stdout/stderr. This makes stdout.write and stderr.write block, until the write is done. BUG=https://code.google.com/p/dart/issues/detail?id=17020 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M runtime/bin/stdio_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-13 10:16:03 UTC) #1
Bill Hesse
LGTM.
6 years, 9 months ago (2014-03-13 10:45:07 UTC) #2
Anders Johnsen
Committed patchset #1 manually as r33645 (presubmit successful).
6 years, 9 months ago (2014-03-13 11:20:43 UTC) #3
Søren Gjesse
6 years, 9 months ago (2014-03-14 08:06:52 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698