Issue 195763028: Support [Transform.hasInput] and [Transform.consumePrimary] in pub.

Issue 195763028: Support [Transform.hasInput] and [Transform.consumePrimary] in pub. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support [Transform.hasInput] and [Transform.consumePrimary] in pub. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33791

Patch Set 2 : code review #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -11 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart	View		3 chunks	+16 lines, -0 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/transformer/can_use_consume_primary_test.dart	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/transformer/can_use_has_input_test.dart	View	1	4 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://codereview.chromium.org/195763028/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/195763028/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode126 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:126: Future<bool> hasInput(AssetId id) { Add a test for these.

6 years, 9 months ago (2014-03-17 21:17:37 UTC) #2

nweiz

6 years, 9 months ago (2014-03-17 22:27:46 UTC) #3

nweiz

6 years, 9 months ago (2014-03-17 23:51:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r33791 (presubmit successful).

Expand Messages | Collapse Messages