Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 195763005: Make service-view programmatically switch views (Closed)

Created:
6 years, 9 months ago by Cutch
Modified:
6 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make service-view programmatically switch views This has the side effect of fixing most of the Polymer exceptions when switching views. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=33630

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -67 lines) Patch
M runtime/bin/vmservice/client/lib/elements.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 2 chunks +116 lines, -2 lines 2 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.html View 1 chunk +0 lines, -65 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/service.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
6 years, 9 months ago (2014-03-12 13:59:26 UTC) #1
turnidge
lgtm w/ comments. https://codereview.chromium.org/195763005/diff/1/runtime/bin/vmservice/client/lib/src/elements/service_view.dart File runtime/bin/vmservice/client/lib/src/elements/service_view.dart (right): https://codereview.chromium.org/195763005/diff/1/runtime/bin/vmservice/client/lib/src/elements/service_view.dart#newcode19 runtime/bin/vmservice/client/lib/src/elements/service_view.dart:19: Maybe a comment saying why we ...
6 years, 9 months ago (2014-03-12 17:46:28 UTC) #2
Cutch
6 years, 9 months ago (2014-03-12 23:32:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698