Issue 19576003: Implement invocation of statics.

Issue 19576003: Implement invocation of statics. (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, rmacnak, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement invocation of statics. BUG=http://dartbug.com/6490 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25102

Patch Set 2 : Add comment and update status file. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -74 lines)			Patch
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	6 chunks	+70 lines, -33 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/dart2js_extra.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/minified_mirrors_test.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirrors_test.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	dart/tests/lib/mirrors/mirrors_test.dart	View		10 chunks	+33 lines, -37 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/19576003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/19576003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode717 dart/sdk/lib/_internal/lib/js_mirrors.dart:717: if (mirror == null || !mirror.isStatic) { If ...

7 years, 5 months ago (2013-07-17 15:26:05 UTC) #2

ahe

Thank you, Nicolas. https://codereview.chromium.org/19576003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/19576003/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode717 dart/sdk/lib/_internal/lib/js_mirrors.dart:717: if (mirror == null || !mirror.isStatic) ...

7 years, 5 months ago (2013-07-17 15:36:54 UTC) #3

ahe

7 years, 5 months ago (2013-07-17 15:37:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25102 (presubmit successful).

Expand Messages | Collapse Messages