Basic tag infrastructure

Basic tag infrastructure

BUG=
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33701

[srdjan, 2014-03-13 20:24:46]

https://codereview.chromium.org/195733009/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/195733009/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:3335: VMTagScope tagScope(VMTag::kScriptTagId,
isolate);
Move isolate to first argument.  See also Issue 196413011

[Cutch, 2014-03-13 21:10:04]

https://codereview.chromium.org/195733009/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/195733009/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:3335: VMTagScope tagScope(VMTag::kScriptTagId,
isolate);
On 2014/03/13 20:24:46, srdjan wrote:
> Move isolate to first argument.  See also Issue 196413011

Done.

[Cutch, 2014-03-13 21:16:03]

Golem runs:

http://108.170.219.2:8080/Comparison#targetA=dart;machineTypeA=linux-ia32;rev...
http://108.170.219.2:8080/Comparison#targetA=dart;machineTypeA=linux-x64;revi...

[siva, 2014-03-13 23:18:47]

I don't see the following transitions
 - to Dart execution
 - from Dart execution to VM
 - native back to VM when entering back through the Dart API

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/isolate.h#new...
runtime/vm/isolate.h:535: uword vm_tag_;
you may have to put this and the accessor method above in BaseIsolate (see
comment in class VMTagScope)

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/native_entry.cc
File runtime/vm/native_entry.cc (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/native_entry....
runtime/vm/native_entry.cc:54: VMTagScope tagScope(isolate,
VMTag::kRuntimeNativeTagId);
This switches the tag to Native but we need to switch back to VM when we
re-enter into the VM using the dart API

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.cc
File runtime/vm/tags.cc (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.cc#newco...
runtime/vm/tags.cc:33: previous_tag_ = isolate_->vm_tag();
isolate()->vm_tag();

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.cc#newco...
runtime/vm/tags.cc:40: isolate_->set_vm_tag(previous_tag_);
isolate()->

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h
File runtime/vm/tags.h (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h#newcode48
runtime/vm/tags.h:48: Isolate* isolate_;
StackResource already has an isolate pointer you don't need this.

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h#newcode49
runtime/vm/tags.h:49: uword previous_tag_;
DISALLOW stuff.

[siva, 2014-03-13 23:20:36]

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h
File runtime/vm/tags.h (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h#newcode20
runtime/vm/tags.h:20: V(RuntimeNative)                                          
                  \
Another tag that Todd had pointed out a while back was Idle (an isolate is idle
waiting in the message loop).

[siva, 2014-03-14 14:58:46]

As discussed offline, this is the initial framework for tags so all the
transition stuff can be done in another CL.

LGTM once the non transition comments are addressed.

[Cutch, 2014-03-14 15:41:48]

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.cc
File runtime/vm/tags.cc (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.cc#newco...
runtime/vm/tags.cc:33: previous_tag_ = isolate_->vm_tag();
On 2014/03/13 23:18:47, siva wrote:
> isolate()->vm_tag();

Done.

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.cc#newco...
runtime/vm/tags.cc:40: isolate_->set_vm_tag(previous_tag_);
On 2014/03/13 23:18:47, siva wrote:
> isolate()->

Done.

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h
File runtime/vm/tags.h (right):

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h#newcode20
runtime/vm/tags.h:20: V(RuntimeNative)                                          
                  \
On 2014/03/13 23:20:36, siva wrote:
> Another tag that Todd had pointed out a while back was Idle (an isolate is
idle
> waiting in the message loop).

Done.

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h#newcode48
runtime/vm/tags.h:48: Isolate* isolate_;
On 2014/03/13 23:18:47, siva wrote:
> StackResource already has an isolate pointer you don't need this.

Done.

https://codereview.chromium.org/195733009/diff/40001/runtime/vm/tags.h#newcode49
runtime/vm/tags.h:49: uword previous_tag_;
On 2014/03/13 23:18:47, siva wrote:
> DISALLOW stuff.

Done.

[Cutch, 2014-03-14 16:16:28]

Committed patchset #6 manually as r33701 (presubmit successful).