Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 19569002: Replace ChainContextInstr with existing IL instructions. (Closed)

Created:
7 years, 5 months ago by Florian Schneider
Modified:
7 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Replace ChainContextInstr with existing IL instructions. v0 <- AllocateContext(...) ChainContext(v0) is changed into v1 <- CurrentContext StoreField(v0.parent = v1) StoreContext(v0) Since v0 is used twice, I used a TempLocalScope in the graph builder to store the allocated context. As a result ChainContextInstr can be completely removed from the compiler. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -120 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +22 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +0 lines, -24 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
This is the first CL in a series to get rid of the remaining inliner ...
7 years, 5 months ago (2013-07-17 12:02:12 UTC) #1
Florian Schneider
Ping.
7 years, 5 months ago (2013-07-18 10:45:16 UTC) #2
srdjan
LGTM, thanks for the cleanup.
7 years, 5 months ago (2013-07-18 16:01:26 UTC) #3
Florian Schneider
7 years, 5 months ago (2013-07-19 09:15:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r25200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698