Issue 19568005: Implement top-level invoke and operators.

Issue 19568005: Implement top-level invoke and operators. (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement top-level invoke and operators. BUG=http://dartbug.com/11861 BUG=http://dartbug.com/6490 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25283

Patch Set 2 : Merged with r25276 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+203 lines, -18 lines)			Patch
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	11 chunks	+66 lines, -16 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/tests/lib/mirrors/mirrors_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	dart/tests/lib/mirrors/operator_test.dart	View	1 chunk	+136 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/19568005/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/19568005/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1067 dart/sdk/lib/_internal/lib/js_mirrors.dart:1067: // Abstract methods are tree-shaken away. Shouldn't you ...

7 years, 5 months ago (2013-07-22 08:54:07 UTC) #2

ahe

Thank you, Nicolas. https://codereview.chromium.org/19568005/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/19568005/diff/1/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1067 dart/sdk/lib/_internal/lib/js_mirrors.dart:1067: // Abstract methods are tree-shaken away. ...

7 years, 5 months ago (2013-07-22 14:57:21 UTC) #3

ahe

7 years, 5 months ago (2013-07-22 16:17:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25283 (presubmit successful).

Expand Messages | Collapse Messages