Issue 19568003: - Make sure to use class X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19568003: - Make sure to use class X. (Closed)

Created:
7 years, 5 months ago by Ivan Posva

Modified:
7 years, 5 months ago

Reviewers:
regis, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Make sure to use class X. Committed: https://code.google.com/p/dart/source/detail?r=25241

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/language/library_ambiguous_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r25241 (presubmit successful).

7 years, 5 months ago (2013-07-19 20:46:04 UTC) #1

regis

7 years, 5 months ago (2013-07-19 21:44:31 UTC) #4

Message was sent while issue was closed.

On 2013/07/19 20:48:47, ahe wrote:
> lgtm

I just talked to Gilad about this case. There is some wiggle room here. As
implementors, we are free to compile the class sooner or later. By adding a use
of X in the test, we force compilation, and thereby remove the wiggle room.

Expand Messages | Collapse Messages