Issue 1956613002: Fix SDK constraints in lockfiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1956613002: Fix SDK constraints in lockfiles. (Closed)

Created:
4 years, 7 months ago by nweiz

Modified:
4 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix SDK constraints in lockfiles. We no longer include overridden dependencies' constraints, since those constraints aren't checked when doing version resolution. In the worst case, including them caused us to generate invalid lockfiles with "<empty>" as the SDK constraint. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/0b96a97d61673cea04f69eb47b2ef2b5b37337d3

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
	M	lib/src/solver/version_solver.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
	M	test/must_pub_get_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 7 months ago (2016-05-05 22:48:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0b96a97d61673cea04f69eb47b2ef2b5b37337d3 (presubmit successful).