Fix a lockfile freshness checking bug.

Fix a lockfile freshness checking bug.

We had a logic error wherein we were checking dependencies only
for cached packages when we should have been checking them only
for *uncached* packages.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/5261d6ade67df67ffd2a021a0a814dfc6ba2d6fa

[Bob Nystrom, 2016-05-05 22:06:42]

https://codereview.chromium.org/1956543002/diff/1/test/must_pub_get_test.dart
File test/must_pub_get_test.dart (right):

https://codereview.chromium.org/1956543002/diff/1/test/must_pub_get_test.dart...
test/must_pub_get_test.dart:308: 'pubspec.lock file was generated, please run
"pub get" again.');
It would be really nice if the error message showed which package's pubspec was
changed. As it is, this is going to very confusingly make people thing the
entrypoint package is the one that changed.

[nweiz, 2016-05-05 22:29:42]

Code review changes

[nweiz, 2016-05-05 22:29:49]

https://codereview.chromium.org/1956543002/diff/1/test/must_pub_get_test.dart
File test/must_pub_get_test.dart (right):

https://codereview.chromium.org/1956543002/diff/1/test/must_pub_get_test.dart...
test/must_pub_get_test.dart:308: 'pubspec.lock file was generated, please run
"pub get" again.');
On 2016/05/05 22:06:42, Bob Nystrom wrote:
> It would be really nice if the error message showed which package's pubspec
was
> changed. As it is, this is going to very confusingly make people thing the
> entrypoint package is the one that changed.

Done.

[Bob Nystrom, 2016-05-05 22:38:37]

lgtm

[nweiz, 2016-05-05 22:40:09]

Description was changed from

==========
Fix a lockfile freshness checking bug.

We had a logic error wherein we were checking dependencies only
for cached packages when we should have been checking them only
for *uncached* packages.

R=rnystrom@google.com
==========

to

==========
Fix a lockfile freshness checking bug.

We had a logic error wherein we were checking dependencies only
for cached packages when we should have been checking them only
for *uncached* packages.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/5261d6ade67df67ffd2a021a0a814dfc6ba2d6fa
==========

[nweiz, 2016-05-05 22:40:10]

Committed patchset #2 (id:20001) manually as
5261d6ade67df67ffd2a021a0a814dfc6ba2d6fa (presubmit successful).