Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 19564013: added generic information (Closed)

Created:
7 years, 5 months ago by janicejl
Modified:
7 years, 5 months ago
Reviewers:
Alan Knight
CC:
Emily Fortuna, Tate Mandel
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M pkg/docgen/lib/docgen.dart View 1 2 7 chunks +33 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
janicejl
7 years, 5 months ago (2013-07-18 21:47:10 UTC) #1
Alan Knight
https://codereview.chromium.org/19564013/diff/2001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/19564013/diff/2001/pkg/docgen/lib/docgen.dart#newcode423 pkg/docgen/lib/docgen.dart:423: var data = {}; Today I learned... you could ...
7 years, 5 months ago (2013-07-18 22:20:46 UTC) #2
janicejl
https://codereview.chromium.org/19564013/diff/2001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/19564013/diff/2001/pkg/docgen/lib/docgen.dart#newcode423 pkg/docgen/lib/docgen.dart:423: var data = {}; On 2013/07/18 22:20:46, Alan Knight ...
7 years, 5 months ago (2013-07-19 01:12:22 UTC) #3
Alan Knight
lgtm
7 years, 5 months ago (2013-07-19 16:42:44 UTC) #4
janicejl
7 years, 5 months ago (2013-07-19 20:11:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r25239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698