Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 19563005: Add a new Dart API call Dart_GetNativeFieldOfArgument (Closed)

Created:
7 years, 5 months ago by siva
Modified:
7 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a new Dart API call Dart_GetNativeFieldOfArgument which combines Dart_GetNativeArgument and Dart_GetNativeInstanceField Dartium always gets the receiver by first getting the NativeArgument corresponding to 0 using Dart_GetNativeArgument and then invokes Dart_GetNativeInstanceField on the returned handle to get the native field corresponding to the native DOM element. When Dartium is changed to use this combined API call the numbers for a sample Dromaeo-drt benchmark is as follows: Dromaeo-drt getAttribute runs-per-second 653.0 Dromaeo-drt element_property_access runs-per-second 579.0 Dromaeo-drt setAttribute runs-per-second 396.0 Dromaeo-drt element_property_assignment runs-per-second 539.0 When the old API calls are used: Dromaeo-drt getAttribute runs-per-second 596.0 Dromaeo-drt element_property_access runs-per-second 528.0 Dromaeo-drt setAttribute runs-per-second 385.0 Dromaeo-drt element_property_assignment runs-per-second 513.49 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25354

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M runtime/include/dart_api.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 5 months ago (2013-07-23 01:17:09 UTC) #1
siva
7 years, 5 months ago (2013-07-23 18:04:04 UTC) #2
srdjan
lgtm
7 years, 5 months ago (2013-07-23 18:13:58 UTC) #3
siva
7 years, 5 months ago (2013-07-23 18:57:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r25354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698