Issue 19558011: Improve certificate tests that hit google.com.

Issue 19558011: Improve certificate tests that hit google.com. (Closed)

Created:
7 years, 5 months ago by Bill Hesse

Modified:
7 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve certificate tests that hit google.com. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25463

Patch Set 2 : add fix for broken Windows compilation. #

Total comments: 2

Patch Set 3 : Pass null instead. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -22 lines)			Patch
M	runtime/vm/benchmark_test.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/standalone/io/secure_no_builtin_roots_database_test.dart	View		1 chunk	+17 lines, -10 lines	0 comments	Download
M	tests/standalone/io/secure_no_builtin_roots_test.dart	View		1 chunk	+17 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Added unrelated fix for broken Windows compilation. PTAL.

7 years, 5 months ago (2013-07-25 09:30:37 UTC) #3

Søren Gjesse

lgtm https://codereview.chromium.org/19558011/diff/3001/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://codereview.chromium.org/19558011/diff/3001/runtime/vm/benchmark_test.cc#newcode472 runtime/vm/benchmark_test.cc:472: Dart_Invoke(lib, NewString("benchmark"), 0, args); Can't args just be ...

7 years, 5 months ago (2013-07-25 09:33:09 UTC) #4

Bill Hesse

Committed patchset #3 manually as r25463 (presubmit successful).

7 years, 5 months ago (2013-07-25 09:37:45 UTC) #5

Bill Hesse

7 years, 5 months ago (2013-07-25 09:37:57 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/19558011/diff/3001/runtime/vm/benchmark_test.cc
File runtime/vm/benchmark_test.cc (right):

https://codereview.chromium.org/19558011/diff/3001/runtime/vm/benchmark_test....
runtime/vm/benchmark_test.cc:472: Dart_Invoke(lib, NewString("benchmark"), 0,
args);
On 2013/07/25 09:33:09, Søren Gjesse wrote:
> Can't args just be NULL here when the number is 0?

Yes it can.  It is not documented in dart_api.h, but the implementation never
uses the args argument if num_args is 0.

Expand Messages | Collapse Messages