Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 19557003: Make the compact VM config keep open a receive port. (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the compact VM config keep open a receive port. R=rnystrom@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M pkg/unittest/lib/compact_vm_config.dart View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 5 months ago (2013-07-17 22:01:24 UTC) #1
Bob Nystrom
+Siggy but LGTM.
7 years, 5 months ago (2013-07-17 22:08:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm! Thanks! I had a feeling we might need that, but forgot to mentioned it ...
7 years, 5 months ago (2013-07-17 22:29:31 UTC) #3
nweiz
7 years, 5 months ago (2013-07-17 22:37:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r25130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698